Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send a dummy insightsStats event to rtc stats #193

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Send a dummy insightsStats event to rtc stats #193

merged 1 commit into from
Jan 18, 2024

Conversation

thyal
Copy link
Member

@thyal thyal commented Jan 17, 2024

Description

The participant insights on the dashboard requires a timeStamp to be able to display the timeline of events.
RTC stats only sets the timeStamp property on the first insightsStats event. Since we are not sending these events from the SDK yet, this PR adds a dummy event, so that the timestamp gets populated.

Summary:

Related Issue:

Testing

  1. Start a session with a few clients
  2. Toggle microphone / camera from the SDK client a few times
  3. End the session
  4. Go to the insights dashboard and find the session
  5. Find the SDK participant, and verify that the timeline is correctly populated with the events

Screenshots/GIFs (if applicable)

Checklist

  • My code follows the project's coding standards.
  • I have written unit tests (if applicable).
  • I have updated the documentation (if applicable).
  • By submitting this pull request, I confirm that my contribution is made
    under the terms of the MIT license.

Dependency Updates

Reviewers

@havardholvik
@kevinwhereby
@nandito
@thyal

Additional Information

@thyal thyal requested a review from a team January 17, 2024 13:35
havardholvik
havardholvik approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@havardholvik havardholvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ref our discussion. Would it be valuable to have an integration test asserting this?

@thyal thyal force-pushed the thomas/PAN-742-rtc-stats-timestamp-fix branch from 1ec170d to 75508c9 Compare January 18, 2024 08:25
@thyal
Copy link
Member Author

thyal commented Jan 18, 2024

Looks good ref our discussion. Would it be valuable to have an integration test asserting this?

Good shout. Added an assertion on the existing integration test for the doRtcAnalyticsCustomEventsInitialize fn

@thyal thyal merged commit f7d1d8a into main Jan 18, 2024
2 checks passed
@thyal thyal deleted the thomas/PAN-742-rtc-stats-timestamp-fix branch January 18, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havardholvik havardholvik havardholvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thyal @havardholvik